lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 18 Aug 2020 13:16:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     awogbemila@...gle.com
Cc:     netdev@...r.kernel.org, sagis@...gle.com, yangchun@...gle.com
Subject: Re: [PATCH net-next 06/18] gve: Batch AQ commands for creating and
 destroying queues.

From: David Awogbemila <awogbemila@...gle.com>
Date: Tue, 18 Aug 2020 12:44:05 -0700

> -int gve_adminq_execute_cmd(struct gve_priv *priv,
> -			   union gve_adminq_command *cmd_orig)
> +static int gve_adminq_issue_cmd(struct gve_priv *priv,
> +				union gve_adminq_command *cmd_orig)
>  {
>  	union gve_adminq_command *cmd;
> +	u32 tail;
>  	u32 opcode;

Please use reverse christmas tree ordering for local variables.

Thanks.

Powered by blists - more mailing lists