lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 18 Aug 2020 14:30:39 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Awogbemila <awogbemila@...gle.com>
Cc:     netdev@...r.kernel.org, Yangchun Fu <yangchun@...gle.com>
Subject: Re: [PATCH net-next 08/18] gve: Enable Link Speed Reporting in the
 driver.

On Tue, 18 Aug 2020 12:44:07 -0700 David Awogbemila wrote:
> This change allows the driver to report the device link speed
> when the ethtool command:
> 	ethtool <nic name>
> is run.
> Getting the link speed is done via a new admin queue command:
> ReportLinkSpeed.
> 
> Reviewed-by: Yangchun Fu <yangchun@...gle.com>
> Signed-off-by: David Awogbemila <awogbemila@...gle.com>

Please make sure the code builds cleanly with W=1 C=1:

drivers/net/ethernet/google/gve/gve_adminq.c:620:28: warning: cast to restricted __be64
drivers/net/ethernet/google/gve/gve_adminq.c:620:28: warning: cast to restricted __be64
drivers/net/ethernet/google/gve/gve_adminq.c:620:28: warning: cast to restricted __be64
drivers/net/ethernet/google/gve/gve_adminq.c:620:28: warning: cast to restricted __be64
drivers/net/ethernet/google/gve/gve_adminq.c:620:28: warning: cast to restricted __be64
drivers/net/ethernet/google/gve/gve_adminq.c:620:28: warning: cast to restricted __be64
drivers/net/ethernet/google/gve/gve_adminq.c:620:28: warning: cast to restricted __be64
drivers/net/ethernet/google/gve/gve_adminq.c:620:28: warning: cast to restricted __be64
drivers/net/ethernet/google/gve/gve_adminq.c:620:28: warning: cast to restricted __be64
drivers/net/ethernet/google/gve/gve_adminq.c:620:28: warning: cast to restricted __be64

Powered by blists - more mailing lists