netdev - Re: [PATCH net-next 10/18] gve: Add support for raw addressing to the rx path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL9ddJcrJScrU94z6O2x4iCoLg=D8Qii+AbTJ87RSBj05LhNkA@mail.gmail.com>
Date:   Tue, 18 Aug 2020 15:25:12 -0700
From:   David Awogbemila <awogbemila@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Catherine Sullivan <csully@...gle.com>,
        Yangchun Fu <yangchun@...gle.com>
Subject: Re: [PATCH net-next 10/18] gve: Add support for raw addressing to the
 rx path

On Tue, Aug 18, 2020 at 1:18 PM David Miller <davem@...emloft.net> wrote:
>
> From: David Awogbemila <awogbemila@...gle.com>
> Date: Tue, 18 Aug 2020 12:44:09 -0700
>
> >  static void gve_rx_free_ring(struct gve_priv *priv, int idx)
> >  {
> >       struct gve_rx_ring *rx = &priv->rx[idx];
> >       struct device *dev = &priv->pdev->dev;
> >       size_t bytes;
> > -     u32 slots;
> > +     u32 slots = rx->mask + 1;
>
> Reverse christmas tree ordering for local variables please.
Got it. I'll fix this.