netdev - Re: [PATCH 2/2 nf] selftests: netfilter: exit on invalid parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200818023935.3bee52fc@elisabeth>
Date:   Tue, 18 Aug 2020 02:39:35 +0200
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Fabian Frederick <fabf@...net.be>
Cc:     pablo@...filter.org, kadlec@...filter.org, fw@...len.de,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH 2/2 nf] selftests: netfilter: exit on invalid parameters

Hi Fabian,

On Fri, 14 Aug 2020 20:55:44 +0200
Fabian Frederick <fabf@...net.be> wrote:

> exit script with comments when parameters are wrong during address
> addition. No need for a message when trying to change MTU with lower
> values: output is self-explanatory
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  tools/testing/selftests/netfilter/nft_flowtable.sh | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tools/testing/selftests/netfilter/nft_flowtable.sh b/tools/testing/selftests/netfilter/nft_flowtable.sh
> index 28e32fddf9b2c..c3617d0037f2e 100755
> --- a/tools/testing/selftests/netfilter/nft_flowtable.sh
> +++ b/tools/testing/selftests/netfilter/nft_flowtable.sh
> @@ -97,9 +97,17 @@ do
>  done
>  
>  ip -net nsr1 link set veth0 mtu $omtu
> +if [ $? -ne 0 ]; then
> +	exit 1
> +fi
> +

As some of your recent patches are also clean-ups, perhaps you get some
assistance from 'shellcheck' (https://www.shellcheck.net/). For
example, this could be written as:

  ip -net nsr1 link set veth0 mtu $omtu || exit 1

or, I'm not sure it's doable, you could get all those checks for free
by setting the -e flag for the entire script. You would then need to
take care explicitly of commands that can legitimately fail.

-- 
Stefano