netdev - Re: [PATCH net] ipv6: some fixes for ipv6_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200818.155925.247746694282898053.davem@davemloft.net>
Date:   Tue, 18 Aug 2020 15:59:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, jmaloy@...hat.com, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net, dsahern@...il.com,
        hideaki.yoshifuji@...aclelinux.com
Subject: Re: [PATCH net] ipv6: some fixes for ipv6_dev_find()

From: Xin Long <lucien.xin@...il.com>
Date: Mon, 17 Aug 2020 14:30:49 +0800

> This patch is to do 3 things for ipv6_dev_find():
> 
>   As David A. noticed,
> 
>   - rt6_lookup() is not really needed. Different from __ip_dev_find(),
>     ipv6_dev_find() doesn't have a compatibility problem, so remove it.
> 
>   As Hideaki suggested,
> 
>   - "valid" (non-tentative) check for the address is also needed.
>     ipv6_chk_addr() calls ipv6_chk_addr_and_flags(), which will
>     traverse the address hash list, but it's heavy to be called
>     inside ipv6_dev_find(). This patch is to reuse the code of
>     ipv6_chk_addr_and_flags() for ipv6_dev_find().
> 
>   - dev parameter is passed into ipv6_dev_find(), as link-local
>     addresses from user space has sin6_scope_id set and the dev
>     lookup needs it.
> 
> Fixes: 81f6cb31222d ("ipv6: add ipv6_dev_find()")
> Suggested-by: YOSHIFUJI Hideaki <hideaki.yoshifuji@...aclelinux.com>
> Reported-by: David Ahern <dsahern@...il.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied, thank you.