netdev - Re: [PATCH v4 1/9] ptp: Add generic ptp v2 header parsing function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Aug 2020 11:37:58 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Kurt Kanzenbach <kurt@...utronix.de>
Cc:     Richard Cochran <richardcochran@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Samuel Zou <zou_wei@...wei.com>, netdev@...r.kernel.org,
        Petr Machata <petrm@...lanox.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH v4 1/9] ptp: Add generic ptp v2 header parsing function

On Tue, Aug 18, 2020 at 12:32:43PM +0200, Kurt Kanzenbach wrote:
> Reason: A lot of the ptp drivers - which implement hardware time stamping - need
> specific fields such as the sequence id from the ptp v2 header. Currently all
> drivers implement that themselves.
> 
> Introduce a generic function to retrieve a pointer to the start of the ptp v2
> header.
> 
> Suggested-by: Russell King <rmk+kernel@...linux.org.uk>
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
> Reviewed-by: Richard Cochran <richardcochran@...il.com>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Just one small nit, see below.  Otherwise,

Reviewed-by: Russell King <rmk+kernel@...linux.org.uk>

> +/**
> + * ptp_parse_header - Get pointer to the PTP v2 header
> + * @skb: packet buffer
> + * @type: type of the packet (see ptp_classify_raw())
> + *
> + * This function takes care of the VLAN, UDP, IPv4 and IPv6 headers. The length
> + * is checked.
> + *
> + * Note, internally skb_mac_header() is used. Make sure, that the @skb is
> + * initialized accordingly.

No need for the "," there - these aren't separate clauses.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!