[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <73712c27-7226-19f3-31be-2d61d2a8bc36@katalix.com>
Date: Wed, 19 Aug 2020 10:01:39 +0100
From: James Chapman <jchapman@...alix.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next] Documentation/networking: update l2tp docs
On 18/08/2020 19:57, Jakub Kicinski wrote:
> On Tue, 18 Aug 2020 16:11:35 +0100 jchapman@...alix.com wrote:
>> From: James Chapman <jchapman@...alix.com>
>>
>> Kernel documentation of L2TP has not been kept up to date and lacks
>> coverage of some L2TP APIs. While addressing this, refactor to improve
>> readability, separating the parts which focus on user APIs and
>> internal implementation into sections.
>>
>> Signed-off-by: James Chapman <jchapman@...alix.com>
> Hi James, checkpatch --strict notices some trailing whitespace here:
>
> ERROR: trailing whitespace
> #301: FILE: Documentation/networking/l2tp.rst:177:
> +PW_TYPE Y Sets the pseudowire type. $
>
> ERROR: trailing whitespace
> #348: FILE: Documentation/networking/l2tp.rst:224:
> +CONN_ID N Identifies the tunnel id to be queried. Ignored for DUMP requests. $
>
> total: 2 errors, 0 warnings, 0 checks, 927 lines checked
>
> Could you clean these up?
Ugh, I should have checked this. I'll spin a v2.
Powered by blists - more mailing lists