lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Aug 2020 16:18:16 +0530 From: Allen <allen.lkml@...il.com> To: Kees Cook <keescook@...omium.org> Cc: James Bottomley <James.Bottomley@...senpartnership.com>, Jens Axboe <axboe@...nel.dk>, Allen Pais <allen.cryptic@...il.com>, jdike@...toit.com, richard@....at, anton.ivanov@...bridgegreys.com, 3chas3@...il.com, stefanr@...6.in-berlin.de, airlied@...ux.ie, daniel@...ll.ch, sre@...nel.org, kys@...rosoft.com, deller@....de, dmitry.torokhov@...il.com, jassisinghbrar@...il.com, shawnguo@...nel.org, s.hauer@...gutronix.de, maximlevitsky@...il.com, oakad@...oo.com, Ulf Hansson <ulf.hansson@...aro.org>, mporter@...nel.crashing.org, alex.bou9@...il.com, broonie@...nel.org, martyn@...chs.me.uk, manohar.vanga@...il.com, mitch@...oth.com, David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org, linux-block@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, openipmi-developer@...ts.sourceforge.net, linux1394-devel@...ts.sourceforge.net, intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, linux-hyperv@...r.kernel.org, linux-parisc@...r.kernel.org, linux-input@...r.kernel.org, linux-mmc@...r.kernel.org, linux-ntb@...glegroups.com, linux-s390@...r.kernel.org, linux-spi@...r.kernel.org, devel@...verdev.osuosl.org, Romain Perier <romain.perier@...il.com> Subject: Re: [PATCH] block: convert tasklets to use new tasklet_setup() API > > > > > > > > > > > > > > > > In preparation for unconditionally passing the > > > > > > > > struct tasklet_struct pointer to all tasklet > > > > > > > > callbacks, switch to using the new tasklet_setup() > > > > > > > > and from_tasklet() to pass the tasklet pointer explicitly. > > > > > > > > > > > > > > Who came up with the idea to add a macro 'from_tasklet' that > > > > > > > is just container_of? container_of in the code would be > > > > > > > _much_ more readable, and not leave anyone guessing wtf > > > > > > > from_tasklet is doing. > > > > > > > > > > > > > > I'd fix that up now before everything else goes in... > > > > > > > > > > > > As I mentioned in the other thread, I think this makes things > > > > > > much more readable. It's the same thing that the timer_struct > > > > > > conversion did (added a container_of wrapper) to avoid the > > > > > > ever-repeating use of typeof(), long lines, etc. > > > > > > > > > > But then it should use a generic name, instead of each sub-system > > > > > using some random name that makes people look up exactly what it > > > > > does. I'm not huge fan of the container_of() redundancy, but > > > > > adding private variants of this doesn't seem like the best way > > > > > forward. Let's have a generic helper that does this, and use it > > > > > everywhere. > > > > > > > > I'm open to suggestions, but as things stand, these kinds of > > > > treewide > > > > > > On naming? Implementation is just as it stands, from_tasklet() is > > > totally generic which is why I objected to it. from_member()? Not > > > great with naming... But I can see this going further and then we'll > > > suddenly have tons of these. It's not good for readability. > > > > Since both threads seem to have petered out, let me suggest in > > kernel.h: > > > > #define cast_out(ptr, container, member) \ > > container_of(ptr, typeof(*container), member) > > > > It does what you want, the argument order is the same as container_of > > with the only difference being you name the containing structure > > instead of having to specify its type. > > I like this! Shall I send this to Linus to see if this can land in -rc2 > for use going forward? > Cool, I shall wait for it to be accepted and then spin out V2 with cast_out() -- - Allen
Powered by blists - more mailing lists