netdev - Re: [PATCH V2 net-next 2/4] net: ena: ethtool: Add new device statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Aug 2020 16:18:56 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     sameehj@...zon.com
Cc:     davem@...emloft.net, netdev@...r.kernel.org, dwmw@...zon.com,
        zorik@...zon.com, matua@...zon.com, saeedb@...zon.com,
        msw@...zon.com, aliguori@...zon.com, nafea@...zon.com,
        gtzalik@...zon.com, netanel@...zon.com, alisaidi@...zon.com,
        benh@...zon.com, akiyano@...zon.com, ndagan@...zon.com
Subject: Re: [PATCH V2 net-next 2/4] net: ena: ethtool: Add new device
 statistics

> +	if (eni_stats_needed) {
> +		ena_update_hw_stats(adapter);
> +		for (i = 0; i < ENA_STATS_ARRAY_ENI(adapter); i++) {
> +			ena_stats = &ena_stats_eni_strings[i];
> +
> +			ptr = (u64 *)((unsigned long)&adapter->eni_stats +
> +				ena_stats->stat_offset);

Yet more ugly casts. Please fix this. If done correctly, you should
not need any casts at all.

    Andrew