netdev - RE: [net-next v3 1/4] devlink: check flash_update parameter support in net core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02874ECE860811409154E81DA85FBB58C8B9BEF6@fmsmsx101.amr.corp.intel.com>
Date:   Wed, 19 Aug 2020 15:53:32 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Jonathan Corbet <corbet@....net>,
        Michael Chan <michael.chan@...adcom.com>,
        Bin Luo <luobin9@...wei.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Leon Romanovsky <leon@...nel.org>,
        Ido Schimmel <idosch@...lanox.com>,
        Danielle Ratson <danieller@...lanox.com>
Subject: RE: [net-next v3 1/4] devlink: check flash_update parameter support
 in net core



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Tuesday, August 18, 2020 8:46 PM
> To: Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: netdev@...r.kernel.org; Jiri Pirko <jiri@...lanox.com>; Jonathan Corbet
> <corbet@....net>; Michael Chan <michael.chan@...adcom.com>; Bin Luo
> <luobin9@...wei.com>; Saeed Mahameed <saeedm@...lanox.com>; Leon
> Romanovsky <leon@...nel.org>; Ido Schimmel <idosch@...lanox.com>;
> Danielle Ratson <danieller@...lanox.com>
> Subject: Re: [net-next v3 1/4] devlink: check flash_update parameter support in
> net core
> 
> On Tue, 18 Aug 2020 17:28:15 -0700 Jacob Keller wrote:
> >  struct devlink_ops {
> > +	/**
> > +	 * @supported_flash_update_params:
> > +	 * mask of parameters supported by the driver's .flash_update
> > +	 * implemementation.
> > +	 */
> > +	u32 supported_flash_update_params;
> 
> To be sure - this doesn't generate W=1 warnings?
> 

I didn't see any pop out in devlink.c with an allyesconfig or an allmodconfig.

> Sadly the posting confused patchwork series grouping and my build tester
> (I think it's the iproute patches mixed with the kernel stuff).

Hmm. I split them up but I guess it still threaded them when I sent them. I'll just send them using two separate send-emails in the future.

Thanks,
Jake