netdev - Re: [PATCH iproute2-next] iproute2: ss: add support to expose various inet sockopts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEA6p_Aot3Ow46D-hxNNfQ2FemNxasR9+zvEto=AX+P7O+kwsA@mail.gmail.com>
Date:   Wed, 19 Aug 2020 09:20:51 -0700
From:   Wei Wang <weiwan@...gle.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Mahesh Bandewar <maheshb@...gle.com>
Subject: Re: [PATCH iproute2-next] iproute2: ss: add support to expose various
 inet sockopts

On Tue, Aug 18, 2020 at 10:46 PM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> On Tue, 18 Aug 2020 16:17:19 -0700
> Wei Wang <weiwan@...gle.com> wrote:
>
> > +                     if (!oneline)
> > +                             out("\n\tinet-sockopt: (");
> > +                     else
> > +                             out(" inet-sockopt: (");
> > +                     out("recverr: %d, ", sockopt->recverr);
> > +                     out("is_icsk: %d, ", sockopt->is_icsk);
> > +                     out("freebind: %d, ", sockopt->freebind);
> > +                     out("hdrincl: %d, ", sockopt->hdrincl);
> > +                     out("mc_loop: %d, ", sockopt->mc_loop);
> > +                     out("transparent: %d, ", sockopt->transparent);
> > +                     out("mc_all: %d, ", sockopt->mc_all);
> > +                     out("nodefrag: %d, ", sockopt->nodefrag);
> > +                     out("bind_addr_no_port: %d, ", sockopt->bind_address_no_port);
> > +                     out("recverr_rfc4884: %d, ", sockopt->recverr_rfc4884);
> > +                     out("defer_connect: %d", sockopt->defer_connect);
>
> Since these are all boolean options why not just print them only if on?
> That saves space and makes more compact output.
>
>                         if (sockopt->recverr) out("recverr, ");


Hmm.. Yes. Will send out v2.