netdev - Re: [PATCH v6 net-next 3/3] octeontx2-pf: Add support for PTP clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200819100036.00007b24@intel.com>
Date:   Wed, 19 Aug 2020 10:00:36 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     <sundeep.lkml@...il.com>
Cc:     <davem@...emloft.net>, <kuba@...nel.org>,
        <richardcochran@...il.com>, <netdev@...r.kernel.org>,
        <sgoutham@...vell.com>, Aleksey Makarov <amakarov@...vell.com>,
        Subbaraya Sundeep <sbhatta@...vell.com>
Subject: Re: [PATCH v6 net-next 3/3] octeontx2-pf: Add support for PTP clock

sundeep.lkml@...il.com wrote:

> From: Aleksey Makarov <amakarov@...vell.com>
> 
> This patch adds PTP clock and uses it in Octeontx2
> network device. PTP clock uses mailbox calls to
> access the hardware counter on the RVU side.
> 
> Co-developed-by: Subbaraya Sundeep <sbhatta@...vell.com>
> Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> Signed-off-by: Aleksey Makarov <amakarov@...vell.com>
> Signed-off-by: Sunil Goutham <sgoutham@...vell.com>

Besides that this driver doesn't have copyrights, I don't see many
problems with this part of the patch. I would like to see some of the
other patches have my comments addressed.

For this patch:
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>