lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 19 Aug 2020 13:17:07 -0500
From:   Cris Forno <cforno12@...ux.ibm.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, drt@...ux.vnet.ibm.com
Subject: Re: [PATCH, net-next, v2] ibmvnic: store RX and TX subCRQ handle array in ibmvnic_adapter struct

David Miller <davem@...emloft.net> writes:

> From: Cristobal Forno <cforno12@...ux.ibm.com>
> Date: Tue, 18 Aug 2020 16:53:33 -0500
>
>> @@ -1524,7 +1519,7 @@ static netdev_tx_t ibmvnic_xmit(struct sk_buff *skb, struct net_device *netdev)
>>  	unsigned int offset;
>>  	int num_entries = 1;
>>  	unsigned char *dst;
>> -	u64 *handle_array;
>> +	u64 handle;
>>  	int index = 0;
>>  	u8 proto = 0;
>>  	netdev_tx_t ret = NETDEV_TX_OK;
>
> Please preserve the reverse christmas tree ordering of local variables
> here.
Sorry, missed that. Sent v3. Thanks David!

--Cris Forno
>
> Otherwise the patch looks fine to me.

Powered by blists - more mailing lists