netdev - Re: [PATCH net-next] net/mlx5: remove erroneous fallthrough

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6eb19690bd2e996d9dfd33361a506af7c53b325.camel@nvidia.com>
Date:   Wed, 19 Aug 2020 19:29:52 +0000
From:   Saeed Mahameed <saeedm@...dia.com>
To:     "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "gustavoars@...nel.org" <gustavoars@...nel.org>
CC:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "leon@...nel.org" <leon@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5: remove erroneous fallthrough

On Mon, 2020-08-03 at 10:48 -0500, Gustavo A. R. Silva wrote:
> On Mon, Aug 03, 2020 at 05:34:48PM +0300, Dan Carpenter wrote:
> > This isn't a fall through because it was after a return
> > statement.  The
> > fall through annotation leads to a Smatch warning:
> > 
> >     drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:246
> >     mlx5e_ethtool_get_sset_count() warn: ignoring unreachable code.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> 

Applied to net-next-mlx5

Thanks!