lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 19 Aug 2020 14:58:46 -0700
From:   Alexei Starovoitov <>
To:     Andrii Nakryiko <>
Subject: Re: [PATCH v3 bpf-next 0/5] Add libbpf support for type- and enum
 value-based CO-RE relocations

On Wed, Aug 19, 2020 at 12:45:14PM -0700, Andrii Nakryiko wrote:
> Selftests are added for all the new features. Selftests utilizing new Clang
> built-ins are designed such that they will compile with older Clangs and will
> be skipped during test runs. So this shouldn't cause any build and test
> failures on systems with slightly outdated Clang compiler.
> LLVM patches adding these relocation in Clang:
>   - __builtin_btf_type_id() ([0], [1], [2]);
>   - __builtin_preserve_type_info(), __builtin_preserve_enum_value() ([3], [4]).
>   [0]
>   [1]
>   [2]
>   [3]
>   [4]

Thank you for listing the above in the commit log, but please follow up with
corresponding update to README.rst and mention the same details there: the
symptoms of missing clang features, which tests are going to be skipped for
older clang, etc.

Also progs/test_core_reloc_type_id.c talks about some bug with
__builtin_preserve_type_info() please add llvm diff number that fixes
it to that .c file.

Powered by blists - more mailing lists