netdev - Re: [net-next v3 1/4] devlink: check flash_update parameter support in net core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Aug 2020 16:36:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jacob.e.keller@...el.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, kuba@...nel.org,
        corbet@....net, michael.chan@...adcom.com, luobin9@...wei.com,
        saeedm@...lanox.com, leon@...nel.org, idosch@...lanox.com,
        danieller@...lanox.com
Subject: Re: [net-next v3 1/4] devlink: check flash_update parameter
 support in net core

From: Jacob Keller <jacob.e.keller@...el.com>
Date: Tue, 18 Aug 2020 17:28:15 -0700

> @@ -991,6 +993,12 @@ enum devlink_trap_group_generic_id {
>  	}
>  
>  struct devlink_ops {
> +	/**
> +	 * @supported_flash_update_params:
> +	 * mask of parameters supported by the driver's .flash_update
> +	 * implemementation.
> +	 */
> +	u32 supported_flash_update_params;
>  	int (*reload_down)(struct devlink *devlink, bool netns_change,
>  			   struct netlink_ext_ack *extack);
>  	int (*reload_up)(struct devlink *devlink,

Jakub asked if this gave W=1 warnings.  Then you responded that you didn't
see any warnings with allmodconfig nor allyesconfig, but that isn't the
question Jakub asked.

Are you building with W=1 explicitly added to the build?

The issue is this kerneldoc might not be formatted correctly, and such
warnings won't be presented without doing a W=1 build.

Thank you.