netdev - Re: [PATCH] net: Avoid strcmp current->comm with warncomm when warned >= 5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <cdcd79834e5145718a224f0610b01a3c@huawei.com>
Date:   Wed, 19 Aug 2020 01:49:43 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kafai@...com" <kafai@...com>, "ast@...nel.org" <ast@...nel.org>,
        "jakub@...udflare.com" <jakub@...udflare.com>,
        "zhang.lin16@....com.cn" <zhang.lin16@....com.cn>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: Avoid strcmp current->comm with warncomm when warned
 >= 5

David Miller <davem@...emloft.net> wrote:
>From: Miaohe Lin <linmiaohe@...wei.com>
>Date: Tue, 18 Aug 2020 07:41:32 -0400
>
>> @@ -417,7 +417,7 @@ static void sock_warn_obsolete_bsdism(const char 
>> *name)  {
>>  	static int warned;
>>  	static char warncomm[TASK_COMM_LEN];
>> -	if (strcmp(warncomm, current->comm) && warned < 5) {
>> +	if (warned < 5 && strcmp(warncomm, current->comm)) {
>>  		strcpy(warncomm,  current->comm);
>>  		pr_warn("process `%s' is using obsolete %s SO_BSDCOMPAT\n",
>>  			warncomm, name);
>
>We've been warning about SO_BSDCOMPAT usage for almost 20 years, I think we can remove this code completely now.

Looks sane. Will do. Many thanks.