lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 19 Aug 2020 08:00:54 +0200
From:   Kurt Kanzenbach <>
To:     Russell King - ARM Linux admin <>
Cc:     Richard Cochran <>,
        Andrew Lunn <>,
        Vivien Didelot <>,
        Florian Fainelli <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Jiri Pirko <>,
        Ido Schimmel <>,
        Heiner Kallweit <>,
        Grygorii Strashko <>,
        Samuel Zou <>,,
        Petr Machata <>,
        Sebastian Andrzej Siewior <>
Subject: Re: [PATCH v4 3/9] net: dsa: mv88e6xxx: Use generic helper function

On Tue Aug 18 2020, Russell King - ARM Linux admin wrote:
> On Tue, Aug 18, 2020 at 12:32:45PM +0200, Kurt Kanzenbach wrote:
>> -static int is_pdelay_resp(u8 *msgtype)
>> +static int is_pdelay_resp(const struct ptp_header *hdr)
>>  {
>> -	return (*msgtype & 0xf) == 3;
>> +	return (hdr->tsmt & 0xf) == 3;
> Forgive my ignorance about PTPv1, but does PTPv1 have these as well?

pdelay is PTP v2 specific. 

> Is there a reason not to use the helper introduced in patch 2 here?

Yes, it doesn't have to be. This driver only deals with PTP v2.

> Should we have definitions for the message types?

That is something one can think of. At the moment there are not many
users though.


Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)

Powered by blists - more mailing lists