netdev - Re: [PATCH v3] ravb: Fixed to be able to unload modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47080d76-8fdd-9222-34c1-3d174ea6bef8@gmail.com>
Date:   Thu, 20 Aug 2020 13:03:07 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Yuusuke Ashizuka <ashiduka@...itsu.com>, davem@...emloft.net,
        kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v3] ravb: Fixed to be able to unload modules

On 20.08.2020 12:43, Yuusuke Ashizuka wrote:

> When this driver is built as a module, I cannot rmmod it after insmoding
> it.
> This is because that this driver calls ravb_mdio_init() at the time of

    "That" not needed here at all; perhaps can be fixed while applying...

> probe, and module->refcnt is incremented by alloc_mdio_bitbang() called
> after that.
> Therefore, even if ifup is not performed, the driver is in use and rmmod
> cannot be performed.
> 
> $ lsmod
> Module                  Size  Used by
> ravb                   40960  1
> $ rmmod ravb
> rmmod: ERROR: Module ravb is in use
> 
> Call ravb_mdio_init() at open and free_mdio_bitbang() at close, thereby
> rmmod is possible in the ifdown state.
> 
> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> Signed-off-by: Yuusuke Ashizuka <ashiduka@...itsu.com>
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@...il.com>
[...]

MBR, Sergei