lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Aug 2020 10:23:56 +0800 From: Yuehaibing <yuehaibing@...wei.com> To: Andrew Lunn <andrew@...n.ch> CC: <peppe.cavallaro@...com>, <alexandre.torgue@...com>, <joabreu@...opsys.com>, <davem@...emloft.net>, <kuba@...nel.org>, <mcoquelin.stm32@...il.com>, <ajayg@...dia.com>, <netdev@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>, <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] net: stmmac: Fix signedness bug in stmmac_probe_config_dt() On 2020/8/19 1:04, Andrew Lunn wrote: > On Tue, Aug 18, 2020 at 11:15:00PM +0800, YueHaibing wrote: >> The "plat->phy_interface" variable is an enum and in this context GCC >> will treat it as an unsigned int so the error handling is never >> triggered. >> >> Fixes: b9f0b2f634c0 ("net: stmmac: platform: fix probe for ACPI devices") >> Signed-off-by: YueHaibing <yuehaibing@...wei.com> > > Hi YueHaibing > > Please take a look at: > > commit 0c65b2b90d13c1deaee6449304dd367c5d4eb8ae > Author: Andrew Lunn <andrew@...n.ch> > Date: Mon Nov 4 02:40:33 2019 +0100 > > net: of_get_phy_mode: Change API to solve int/unit warnings > > You probably want to follow this basic idea. > Thanks, will rework following this. > Andrew > > . >
Powered by blists - more mailing lists