netdev - Re: [PATCH bpf-next 1/4] libbpf: fix detection of BPF helper call instruction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2801a3a2-81a3-c3a9-9e9c-3fc5153334b1@fb.com>
Date:   Thu, 20 Aug 2020 07:17:48 -0700
From:   Yonghong Song <yhs@...com>
To:     Andrii Nakryiko <andriin@...com>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>, <ast@...com>, <daniel@...earbox.net>
CC:     <andrii.nakryiko@...il.com>, <kernel-team@...com>
Subject: Re: [PATCH bpf-next 1/4] libbpf: fix detection of BPF helper call
 instruction



On 8/19/20 11:14 PM, Andrii Nakryiko wrote:
> BPF_CALL | BPF_JMP32 is explicitly not allowed by verifier for BPF helper
> calls, so don't detect it as a valid call. Also drop the check on func_id
> pointer, as it's currently always non-null.
> 
> Reported-by: Yonghong Song <yhs@...com>
> Fixes: 109cea5a594f ("libbpf: Sanitize BPF program code for bpf_probe_read_{kernel, user}[_str]")
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Acked-by: Yonghong Song <yhs@...com>