netdev - Re: [PATCH ipsec-next v2] xfrm: add /proc/sys/core/net/xfrm_redact

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60709458-cc80-9015-e507-137b80c78660@6wind.com>
Date:   Thu, 20 Aug 2020 17:14:52 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     antony.antony@...unet.com,
        Steffen Klassert <steffen.klassert@...unet.com>,
        netdev@...r.kernel.org, Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Antony Antony <antony@...nome.org>,
        Stephan Mueller <smueller@...onox.de>
Subject: Re: [PATCH ipsec-next v2] xfrm: add
 /proc/sys/core/net/xfrm_redact_secret

Le 20/08/2020 à 14:04, Antony Antony a écrit :
[snip]
> @@ -38,6 +48,15 @@ static struct ctl_table xfrm_table[] = {
>  		.mode		= 0644,
>  		.proc_handler	= proc_dointvec
>  	},
> +	{
> +		.procname	= "xfrm_redact_secret",
> +		.maxlen		= sizeof(u32),
> +		.mode		= 0644,
> +		/* only handle a transition from "0" to "1" */
> +		.proc_handler	= proc_dointvec_minmax,
> +		.extra1         = SYSCTL_ONE,
> +		.extra2         = SYSCTL_ONE,
nit for the v3: the '=' of the last two lines is aligned with spaces while the
first lines use tabs.