lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 20 Aug 2020 23:29:45 +0800
From:   Chuanhong Guo <>
To:     René van Dorst <>
Cc:     Landen Chao <>,
        Andrew Lunn <>,
        Florian Fainelli <>,,
        Matthias Brugger <>,
        Rob Herring <>,
        Mark Rutland <>,
        <>, netdev <>,
        open list <>,
        "moderated list:ARM/Mediatek SoC support" 
        "David S. Miller" <>,
        Sean Wang <>,,
        DENG Qingfang <>
Subject: Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of
 MT7531 switch


On Thu, Aug 20, 2020 at 7:55 AM René van Dorst <> wrote:
> With the current mainline code [1], the dsa code tries to detect how the MAC5
> is used. All the three modes are supported. MAC5 -> PHY0, MAC5 ->
> PHY4, MAC5 ->
> EXTERNAL PHY and MAC5 to external MAC.
> When MAC5 is a DSA port it skips settings the delay settings. See [2].
> Maybe you can use a similar concept.

Current detection relies on an incorrect assumption that mt753x switch
is always used with mtk_eth_soc. It's a really hacky solution to use
dt properties that don't belong to this switch at all and I think this
approach should not be followed further by future code.
The usage of mac5 should be explicitly defined as a dt property
under mt753x node.
Chuanhong Guo

Powered by blists - more mailing lists