netdev - Re: [PATCH net 1/1] net/smc: Prevent kernel-infoleak in __smc_diag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Aug 2020 12:09:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ubraun@...ux.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        heiko.carstens@...ibm.com, kgraul@...ux.ibm.com,
        raspl@...ux.ibm.com, yepeilin.cs@...il.com
Subject: Re: [PATCH net 1/1] net/smc: Prevent kernel-infoleak in
 __smc_diag_dump()

From: Ursula Braun <ubraun@...ux.ibm.com>
Date: Thu, 20 Aug 2020 16:30:52 +0200

> From: Peilin Ye <yepeilin.cs@...il.com>
> 
> __smc_diag_dump() is potentially copying uninitialized kernel stack memory
> into socket buffers, since the compiler may leave a 4-byte hole near the
> beginning of `struct smcd_diag_dmbinfo`. Fix it by initializing `dinfo`
> with memset().
> 
> Cc: stable@...r.kernel.org

Please do not CC: stable for networking patches as per the netdev FAQ.

> Fixes: 4b1b7d3b30a6 ("net/smc: add SMC-D diag support")
> Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Peilin Ye <yepeilin.cs@...il.com>
> Signed-off-by: Ursula Braun <ubraun@...ux.ibm.com>

Applied and queued up for -stable, thank you.