netdev - Re: [PATCH bpf-next 1/3] bpf: implement link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200820223111.6dbbp53rpszht4uf@ast-mbp.dhcp.thefacebook.com>
Date:   Thu, 20 Aug 2020 15:31:11 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     Jakub Kicinski <kuba@...nel.org>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, kernel-team@...com
Subject: Re: [PATCH bpf-next 1/3] bpf: implement link_query for bpf iterators

On Thu, Aug 20, 2020 at 09:15:30AM -0700, Yonghong Song wrote:
> 
> 
> On 8/20/20 8:07 AM, Jakub Kicinski wrote:
> > On Wed, 19 Aug 2020 17:13:23 -0700 Yonghong Song wrote:
> > > +	fill_link_info = iter_link->tinfo->reg_info->fill_link_info;
> > > +	if (fill_link_info)
> > > +		return fill_link_info(&iter_link->aux, info);
> > > +
> > > +        return 0;
> > 
> > ERROR: code indent should use tabs where possible
> > #138: FILE: kernel/bpf/bpf_iter.c:433:
> > +        return 0;$
> > 
> > WARNING: please, no spaces at the start of a line
> > #138: FILE: kernel/bpf/bpf_iter.c:433:
> > +        return 0;$
> 
> 
> Thanks for reporting! Will wait a little bit for further
> comments and send v2.

all looks good to me.