netdev - Re: [PATCH] gre6: Fix reception with IP6_TNL_F_RCV_DSCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200820.162905.221555195371922950.davem@davemloft.net>
Date:   Thu, 20 Aug 2020 16:29:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mark.tomlinson@...iedtelesis.co.nz
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gre6: Fix reception with IP6_TNL_F_RCV_DSCP_COPY

From: Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>
Date: Wed, 19 Aug 2020 13:53:58 +1200

> When receiving an IPv4 packet inside an IPv6 GRE packet, and the
> IP6_TNL_F_RCV_DSCP_COPY flag is set on the tunnel, the IPv4 header would
> get corrupted. This is due to the common ip6_tnl_rcv() function assuming
> that the inner header is always IPv6. This patch checks the tunnel
> protocol for IPv4 inner packets, but still defaults to IPv6.
> 
> Fixes: 308edfdf1563 ("gre6: Cleanup GREv6 receive path, call common GRE functions")
> Signed-off-by: Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>

Applied and queued up for -stable, thank you.