netdev - Re: [PATCH bpf-next 10/16] libbpf: implement generalized .BTF.ext func/line info adjustment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzbeaUZ5Uxaq8URxKtstoA6UN8vnFQWjTpuSL4HMfS0m5g@mail.gmail.com>
Date:   Thu, 20 Aug 2020 16:31:06 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Andrii Nakryiko <andriin@...com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next 10/16] libbpf: implement generalized .BTF.ext
 func/line info adjustment

On Thu, Aug 20, 2020 at 4:13 PM Andrii Nakryiko <andriin@...com> wrote:
>
> Complete multi-prog sections and multi sub-prog support in libbpf by properly
> adjusting .BTF.ext's line and function information. Mark exposed
> btf_ext__reloc_func_info() and btf_ext__reloc_func_info() APIs as deprecated.
> These APIs have simplistic assumption that all sub-programs are going to be
> appended to all main BPF programs, which doesn't hold in real life. It's
> unlikely there are any users of this API, as it's very libbpf
> internals-specific.
>
> Signed-off-by: Andrii Nakryiko <andriin@...com>
> ---
>  tools/lib/bpf/btf.h           |  18 +--
>  tools/lib/bpf/libbpf.c        | 217 ++++++++++++++++++++++------------
>  tools/lib/bpf/libbpf_common.h |   2 +
>  3 files changed, 153 insertions(+), 84 deletions(-)
>

[...]

> diff --git a/tools/lib/bpf/libbpf_common.h b/tools/lib/bpf/libbpf_common.h
> index a23ae1ac27eb..145ddff57235 100644
> --- a/tools/lib/bpf/libbpf_common.h
> +++ b/tools/lib/bpf/libbpf_common.h
> @@ -15,6 +15,8 @@
>  #define LIBBPF_API __attribute__((visibility("default")))
>  #endif
>
> +#define DEPRECATED(msg) __attribute__((deprecated(msg)))

Given this will end up in user code, it seems like using
LIBBPF_DEPRECATED would be a better choice. I'll update for v2.

> +
>  /* Helper macro to declare and initialize libbpf options struct
>   *
>   * This dance with uninitialized declaration, followed by memset to zero,
> --
> 2.24.1
>