netdev - Re: [PATCH net] net/sched: act_ct: Fix skb double-free in tcf_ct_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200820.164036.1350126703880055200.davem@davemloft.net>
Date:   Thu, 20 Aug 2020 16:40:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     alaa@...lanox.com
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com,
        marcelo.leitner@...il.com, roid@...lanox.com
Subject: Re: [PATCH net] net/sched: act_ct: Fix skb double-free in
 tcf_ct_handle_fragments() error flow

From: Alaa Hleihel <alaa@...lanox.com>
Date: Wed, 19 Aug 2020 18:24:10 +0300

> tcf_ct_handle_fragments() shouldn't free the skb when ip_defrag() call
> fails. Otherwise, we will cause a double-free bug.
> In such cases, just return the error to the caller.
> 
> Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct")
> Signed-off-by: Alaa Hleihel <alaa@...lanox.com>
> Reviewed-by: Roi Dayan <roid@...lanox.com>

Applied and queued up for -stable, thank you.