lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 20 Aug 2020 09:21:11 +0200
From:   Mauro Carvalho Chehab <>
To:     Sam Ravnborg <>
Cc:     Greg Kroah-Hartman <>,
        Neil Armstrong <>,
        Xinliang Liu <>,
        Wanchun Zheng <>,, dri-devel <>,
        Andrzej Hajda <>,
        Laurent Pinchart <>,, Daniel Borkmann <>,
        John Fastabend <>,
        Xiubin Zhang <>,
        Wei Xu <>, David Airlie <>,
        Xinwei Kong <>,
        Tomi Valkeinen <>,
        Bogdan Togorean <>,
        Laurentiu Palcu <>,,,
        Liwei Cai <>,
        Jesper Dangaard Brouer <>,
        Manivannan Sadhasivam <>,
        Chen Feng <>,
        Alexei Starovoitov <>,, Rob Herring <>,
        Jakub Kicinski <>,,
        Rob Clark <>,,,, Liuyao An <>,
        Rongrong Zou <>,,
        "David S. Miller" <>
Subject: Re: [PATCH 00/49] DRM driver for Hikey 970

Hi Sam,

Em Wed, 19 Aug 2020 22:48:00 +0200
Sam Ravnborg <> escreveu:

> Hi Mauro.
> It seems my review comments failed to reach dri-devel - likely due to
> the size of the mail.

Probably. It reached here properly.

> Link:
> I my review feedback I refer to checkpatch a few time.
> For drivers/gpu/ we have some nice tooling support.
> One thing our tooling does for us is running checkpatch every time
> we apply a patch.
>     checkpatch -q --emacs --strict --show-types
> So we expect patches to be more or less checkpatch --strict clean.
> "more or less" - as common sense also plays a role.
> And sometimes checkpatch is just wrong.
> Just in case you wondered why checkpatch --strict was requested.

We also use checkpatch --strict for media as a reference,
ignoring the things that would make things worse during review :-)

I'll run checkpatch here and ensure that the coding style
issues will be properly addressed.


Powered by blists - more mailing lists