netdev - Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200820213649.7cd6aa3f@hermes.lan>
Date:   Thu, 20 Aug 2020 21:36:49 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     dsahern@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 net-next] iplink: add support for protodown
 reason

On Thu, 20 Aug 2020 20:52:02 -0700
Roopa Prabhu <roopa@...ulusnetworks.com> wrote:

> +	if (tb[IFLA_PROTO_DOWN]) {
> +		if (rta_getattr_u8(tb[IFLA_PROTO_DOWN]))
> +			print_bool(PRINT_ANY,
> +				   "proto_down", " protodown on ", true);

In general my preference is to use print_null() for presence flags.
Otherwise you have to handle the false case in JSON as a special case.