netdev - Re: [PATCH v6 net-next 04/10] qed: implement devlink info request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200821103218.6d1cb211@kicinski-fedora-PC1C0HJN>
Date:   Fri, 21 Aug 2020 10:32:18 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Igor Russkikh <irusskikh@...vell.com>
Cc:     <netdev@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>,
        Ariel Elior <aelior@...vell.com>,
        Michal Kalderon <mkalderon@...vell.com>,
        "Alexander Lobakin" <alobakin@...vell.com>,
        Michal Kalderon <michal.kalderon@...vell.com>
Subject: Re: [PATCH v6 net-next 04/10] qed: implement devlink info request

On Thu, 20 Aug 2020 21:51:58 +0300 Igor Russkikh wrote:
> Here we return existing fw & mfw versions, we also fetch device's
> serial number:
> 
> ~$ sudo ~/iproute2/devlink/devlink  dev info
> pci/0000:01:00.1:
>   driver qed
>   board.serial_number REE1915E44552
>   versions:
>       running:
>         fw.app 8.42.2.0
>       stored:
>         fw.mgmt 8.52.10.0

Are you not able to report the running version of the stored firmware?
The two sections are used for checking if machine needs fw-activation
or reboot (i.e. if fw.mgmt in stored section does not match fw.mgmt in
running - there is a new FW to activate).

> MFW and FW are different firmwares on device.
> Management is a firmware responsible for link configuration and
> various control plane features. Its permanent and resides in NVM.
> 
> Running FW (or fastpath FW) is an embedded microprogram implementing
> all the packet processing, offloads, etc. This FW is being loaded
> on each start by the driver from FW binary blob.
> 
> The base device specific structure (qed_dev_info) was not directly
> available to the base driver before. Thus, here we create and store
> a private copy of this structure in qed_dev root object to
> access the data.

In general looks good:

Reviewed-by: Jakub Kicinski <kuba@...nel.org>