netdev - Re: [PATCH bpf-next v4 0/3] bpf: implement link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZQOz_uBkSOSXRXvc2nb0y5FUvT7x_SWwCbgwzwQKVdBg@mail.gmail.com>
Date:   Fri, 21 Aug 2020 12:04:16 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next v4 0/3] bpf: implement link_query for bpf iterators

On Fri, Aug 21, 2020 at 11:44 AM Yonghong Song <yhs@...com> wrote:
>
> "link" has been an important concept for bpf ecosystem to connect
> bpf program with other properties. Currently, the information related
> information can be queried from userspace through bpf command
> BPF_LINK_GET_NEXT_ID, BPF_LINK_GET_FD_BY_ID and BPF_OBJ_GET_INFO_BY_FD.
> The information is also available by "cating" /proc/<pid>/fdinfo/<link_fd>.
> Raw_tracepoint, tracing, cgroup, netns and xdp links are already
> supported in the kernel and bpftool.
>
> This patch added support for bpf iterator. Patch #1 added generic support
> for link querying interface. Patch #2 implemented callback functions
> for map element bpf iterators. Patch #3 added bpftool support.
>
> Changelogs:
>   v3 -> v4:
>     . return target specific link_info even if target_name buffer
>       is empty. (Andrii)
>   v2 -> v3:
>     . remove extra '\t' when fdinfo prints map_id to make parsing
>       consistent. (Andrii)
>   v1 -> v2:
>     . fix checkpatch.pl warnings. (Jakub)
>
> Yonghong Song (3):
>   bpf: implement link_query for bpf iterators
>   bpf: implement link_query callbacks in map element iterators
>   bpftool: implement link_query for bpf iterators
>
>  include/linux/bpf.h            | 10 ++++++
>  include/uapi/linux/bpf.h       |  7 ++++
>  kernel/bpf/bpf_iter.c          | 58 ++++++++++++++++++++++++++++++++++
>  kernel/bpf/map_iter.c          | 15 +++++++++
>  net/core/bpf_sk_storage.c      |  2 ++
>  tools/bpf/bpftool/link.c       | 44 ++++++++++++++++++++++++--
>  tools/include/uapi/linux/bpf.h |  7 ++++
>  7 files changed, 140 insertions(+), 3 deletions(-)
>
> --
> 2.24.1
>

LGTM, thanks.

Acked-by: Andrii Nakryiko <andriin@...com>