netdev - Re: [PATCH net-next 2/2] io_uring: ignore POLLIN for recvmsg on MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200821134144.642f6fbb@kicinski-fedora-PC1C0HJN>
Date:   Fri, 21 Aug 2020 13:41:44 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Luke Hsiao <luke.w.hsiao@...il.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Jens Axboe <axboe@...nel.dk>,
        Luke Hsiao <lukehsiao@...gle.com>,
        Arjun Roy <arjunroy@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 2/2] io_uring: ignore POLLIN for recvmsg on
 MSG_ERRQUEUE

On Thu, 20 Aug 2020 16:49:54 -0700 Luke Hsiao wrote:
> +	/* If reading from MSG_ERRQUEUE using recvmsg, ignore POLLIN */
> +	if (req->opcode == IORING_OP_RECVMSG && (sqe->msg_flags & MSG_ERRQUEUE))
> +		mask &= ~(POLLIN);

FWIW this adds another W=1 C=1 warnings to this code:

fs/io_uring.c:4940:22: warning: invalid assignment: &=
fs/io_uring.c:4940:22:    left side has type restricted __poll_t
fs/io_uring.c:4940:22:    right side has type int


And obviously the brackets around POLLIN are not necessary.