netdev - Re: [PATCH bpf-next v2 3/3] bpftool: implement link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzYtATdmP7GCQahu6SiYRv+oxAxPm42icTbpDoAHFo8z=Q@mail.gmail.com>
Date:   Thu, 20 Aug 2020 23:35:44 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next v2 3/3] bpftool: implement link_query for bpf iterators

On Thu, Aug 20, 2020 at 3:50 PM Yonghong Song <yhs@...com> wrote:
>
> The link query for bpf iterators is implemented.
> Besides being shown to the user what bpf iterator
> the link represents, the target_name is also used
> to filter out what additional information should be
> printed out, e.g., whether map_id should be shown or not.
> The following is an example of bpf_iter link dump,
> plain output or pretty output.
>
>   $ bpftool link show
>   11: iter  prog 59  target_name task
>           pids test_progs(1749)
>   34: iter  prog 173  target_name bpf_map_elem  map_id 127
>           pids test_progs_1(1753)
>   $ bpftool -p link show
>   [{
>           "id": 11,
>           "type": "iter",
>           "prog_id": 59,
>           "target_name": "task",
>           "pids": [{
>                   "pid": 1749,
>                   "comm": "test_progs"
>               }
>           ]
>       },{
>           "id": 34,
>           "type": "iter",
>           "prog_id": 173,
>           "target_name": "bpf_map_elem",
>           "map_id": 127,
>           "pids": [{
>                   "pid": 1753,
>                   "comm": "test_progs_1"
>               }
>           ]
>       }
>   ]
>
> Signed-off-by: Yonghong Song <yhs@...com>
> ---

LGTM.

Acked-by: Andrii Nakryiko <andriin@...com>

>  tools/bpf/bpftool/link.c | 44 +++++++++++++++++++++++++++++++++++++---
>  1 file changed, 41 insertions(+), 3 deletions(-)
>

[...]