lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Aug 2020 08:16:29 +0100 From: Lee Jones <lee.jones@...aro.org> To: kvalo@...eaurora.org, davem@...emloft.net, kuba@...nel.org Cc: linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, Lee Jones <lee.jones@...aro.org>, "Alexander A. Klimov" <grandmaster@...klimov.de>, b43-dev@...ts.infradead.org Subject: [PATCH 17/32] wireless: broadcom: b43: phy_ht: Remove 9 year old TODO Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/b43/phy_ht.c: In function ‘b43_phy_ht_op_init’: drivers/net/wireless/broadcom/b43/phy_ht.c:904:3: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] Cc: Kalle Valo <kvalo@...eaurora.org> Cc: "David S. Miller" <davem@...emloft.net> Cc: Jakub Kicinski <kuba@...nel.org> Cc: "Alexander A. Klimov" <grandmaster@...klimov.de> Cc: linux-wireless@...r.kernel.org Cc: b43-dev@...ts.infradead.org Cc: netdev@...r.kernel.org Signed-off-by: Lee Jones <lee.jones@...aro.org> --- drivers/net/wireless/broadcom/b43/phy_ht.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/broadcom/b43/phy_ht.c b/drivers/net/wireless/broadcom/b43/phy_ht.c index c685b4bb5ed6e..d050971d150a5 100644 --- a/drivers/net/wireless/broadcom/b43/phy_ht.c +++ b/drivers/net/wireless/broadcom/b43/phy_ht.c @@ -900,9 +900,6 @@ static int b43_phy_ht_op_init(struct b43_wldev *dev) b43_phy_write(dev, 0x70, 0x50); b43_phy_write(dev, 0x1ff, 0x30); - if (0) /* TODO: condition */ - ; /* TODO: PHY op on reg 0x217 */ - if (b43_current_band(dev->wl) == NL80211_BAND_5GHZ) b43_phy_ht_classifier(dev, B43_PHY_HT_CLASS_CTL_CCK_EN, 0); else -- 2.25.1
Powered by blists - more mailing lists