netdev - Re: [RFC PATCH] net: bridge: Don't reset time stamps on SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mu2oe8z6.fsf@kurt>
Date:   Fri, 21 Aug 2020 09:47:25 +0200
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        bridge@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [RFC PATCH] net: bridge: Don't reset time stamps on SO_TXTIME enabled sockets

On Thu Aug 20 2020, Nikolay Aleksandrov wrote:
> The new conditionals will be for all forwarded packets, not only the
> ones that are transmitted through the bridge master device.

I see makes sense.

> If you'd like to do this please limit it to the bridge dev transmit.

I'm wondering how to do that. The problem is that the time stamp is
reset to zero unconditionally in br_forward_finish(). This function is
also called in the transmit path.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)