netdev - Re: [PATCH net-next] net: Remove unnecessary intermediate variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Aug 2020 14:03:31 -0700
From:   Joe Perches <joe@...ches.com>
To:     David Miller <davem@...emloft.net>
Cc:     Jianlin.Lv@....com, netdev@...r.kernel.org, kuba@...nel.org,
        Song.Zhu@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: Remove unnecessary intermediate variables

On Sat, 2020-08-22 at 13:59 -0700, David Miller wrote:
> From: Joe Perches <joe@...ches.com>
> Date: Sat, 22 Aug 2020 13:39:28 -0700
> 
> > It _might_ be slightly faster to use inlines
> 
> We are not using the inline directive in foo.c files and are letting
> the compiler decide.
> 
> Please don't give out advice like this.

Actually, I checked with and without inline
before posting the proposal.

The compiler didn't inline the code without it.
Not even with just static inline.
For gcc 9.3 only the __always_inline did.
That's the only version I checked.