lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Aug 2020 12:42:09 -0700 (PDT) From: David Miller <davem@...emloft.net> To: nikolay@...ulusnetworks.com Cc: netdev@...r.kernel.org, dsahern@...il.com, syzbot+a61aa19b0c14c8770bd9@...kaller.appspotmail.com Subject: Re: [PATCH net v2] net: nexthop: don't allow empty NHA_GROUP From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com> Date: Sat, 22 Aug 2020 15:06:36 +0300 > Currently the nexthop code will use an empty NHA_GROUP attribute, but it > requires at least 1 entry in order to function properly. Otherwise we > end up derefencing null or random pointers all over the place due to not > having any nh_grp_entry members allocated, nexthop code relies on having at > least the first member present. Empty NHA_GROUP doesn't make any sense so > just disallow it. > Also add a WARN_ON for any future users of nexthop_create_group(). ... > CC: David Ahern <dsahern@...il.com> > Fixes: 430a049190de ("nexthop: Add support for nexthop groups") > Reported-by: syzbot+a61aa19b0c14c8770bd9@...kaller.appspotmail.com > Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com> Applied and queued up for -stable, thanks.
Powered by blists - more mailing lists