lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Aug 2020 12:59:08 -0700 From: Pascal Bouchareine <kalou@....net> To: David Miller <davem@...emloft.net> Cc: linux-kernel@...r.kernel.org, linux-api@...r.kernel.org, netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, Alexey Dobriyan <adobriyan@...il.com>, Al Viro <viro@...iv.linux.org.uk> Subject: Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION Thank you, On Sat, Aug 22, 2020 at 12:36 PM David Miller <davem@...emloft.net> wrote: > > We ignore optlen and constrain the string to a static max size > > > > Signed-off-by: Pascal Bouchareine <kalou@....net> > > This change is really a non-starter unless the information gets > published somewhere where people actually look at dumped sockets, and > that's inet_diag and friends. Would it make sense to also make UDIAG_SHOW_NAME use sk_description? (And keep the existing change - setsockopt + show_fd_info via /proc/.../fdinfo/..) I would feel like adding a pid information (and what else am I missing here) to inet_diag might also be a good improvement then? I understand that users have to scan /proc to find the FDs, matching the inode number for the socket to find the owning process today. If that's of interest I can explore that too
Powered by blists - more mailing lists