netdev - Regarding possible bug in net/wan/x25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=jOEY=8T3-USi63hy47BZKfTYcsUw-s-jAc3xi9ksk-je+XA@mail.gmail.com>
Date:   Sun, 23 Aug 2020 20:58:33 +0530
From:   Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
To:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, xie.he.0141@...il.com
Cc:     andrianov <andrianov@...ras.ru>, netdev <netdev@...r.kernel.org>
Subject: Regarding possible bug in net/wan/x25_asy.c

Hello,

I have the following doubt:

sl->xhead is modified in both x25_asy_change_mtu() and
x25_asy_write_wakeup(). However, sl->lock is not held in
x25_asy_write_wakeup(). So, I am not sure if it is indeed possible to
have a race between these two functions. If it is possible that these
two functions can execute in parallel then the lock should be held in
x25_asy_write_wakeup() as well. Please let me know if this race is
possible.

Thanks and regards,
Madhuparna