netdev - Re: [PATCH ethtool] cable-test: TDR Amplitude is signed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200823160401.i7kngascbvh2r2mg@lion.mk-sys.cz>
Date:   Sun, 23 Aug 2020 18:04:01 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH ethtool] cable-test: TDR Amplitude is signed

On Sun, Aug 16, 2020 at 05:25:08PM +0200, Andrew Lunn wrote:
> Use the signed JSON helper for printing the TDR amplitude. Otherwise
> negative values, i.e. cable shorts, become very large positive values.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied, thank you.

Michal

> ---
>  netlink/cable_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/netlink/cable_test.c b/netlink/cable_test.c
> index d39b7d8..8a71453 100644
> --- a/netlink/cable_test.c
> +++ b/netlink/cable_test.c
> @@ -354,7 +354,7 @@ static int nl_cable_test_tdr_ntf_attr(struct nlattr *evattr)
>  
>  		open_json_object(NULL);
>  		print_string(PRINT_ANY, "pair", "%s ", nl_pair2txt(pair));
> -		print_uint(PRINT_ANY, "amplitude", "Amplitude %4d\n", mV);
> +		print_int(PRINT_ANY, "amplitude", "Amplitude %4d\n", mV);
>  		close_json_object();
>  		break;
>  	}
> -- 
> 2.27.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)