netdev - [PATCH] ioctl: only memset non-NULL link settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200824064630.3836539-1-hegtvedt@cisco.com>
Date:   Mon, 24 Aug 2020 08:46:30 +0200
From:   Hans-Christian Noren Egtvedt <hegtvedt@...co.com>
To:     netdev@...r.kernel.org
Cc:     Hans-Christian Noren Egtvedt <hegtvedt@...co.com>
Subject: [PATCH] ioctl: only memset non-NULL link settings

In commit bef780467fa ('ioctl: do not pass transceiver value back to
kernel') a regression slipped. If we have a kernel that does not support
the ETHTOOL_xLINKSETTINGS API, then the do_ioctl_glinksettings()
function will return a NULL pointer.

Hence before memset'ing the pointer to zero we must first check it is
valid, as NULL return is perfectly fine when running on old kernels.

Signed-off-by: Hans-Christian Noren Egtvedt <hegtvedt@...co.com>
---
 ethtool.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/ethtool.c b/ethtool.c
index c4ad186..8267d6b 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -2908,8 +2908,10 @@ static int do_sset(struct cmd_context *ctx)
 		struct ethtool_link_usettings *link_usettings;
 
 		link_usettings = do_ioctl_glinksettings(ctx);
-		memset(&link_usettings->deprecated, 0,
-		       sizeof(link_usettings->deprecated));
+		if (link_usettings) {
+			memset(&link_usettings->deprecated, 0,
+			       sizeof(link_usettings->deprecated));
+		}
 		if (link_usettings == NULL)
 			link_usettings = do_ioctl_gset(ctx);
 		if (link_usettings == NULL) {
-- 
2.25.1