lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 24 Aug 2020 10:58:37 -0700
From:   Florian Fainelli <>
To:     Geert Uytterhoeven <>,
        "David S . Miller" <>,
        Jakub Kicinski <>,
        Rob Herring <>,
        Sergei Shtylyov <>
Cc:     Andrew Lunn <>,
        Oleksij Rempel <>,
        Philippe Schenker <>,
        Heiner Kallweit <>,
        Dan Murphy <>,
        Kazuya Mizuguchi <>,
        Wolfram Sang <>,
        Magnus Damm <>,,,,
Subject: Re: [PATCH v3 5/7] ravb: Add support for explicit internal clock
 delay configuration

On 8/19/20 6:43 AM, Geert Uytterhoeven wrote:
> Some EtherAVB variants support internal clock delay configuration, which
> can add larger delays than the delays that are typically supported by
> the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps"
> properties).
> Historically, the EtherAVB driver configured these delays based on the
> "rgmii-*id" PHY mode.  This caused issues with PHY drivers that
> implement PHY internal delays properly[1].  Hence a backwards-compatible
> workaround was added by masking the PHY mode[2].
> Add proper support for explicit configuration of the MAC internal clock
> delays using the new "[rt]x-internal-delay-ps" properties.
> Fall back to the old handling if none of these properties is present.
> [1] Commit bcf3440c6dd78bfe ("net: phy: micrel: add phy-mode support for
>     the KSZ9031 PHY")
> [2] Commit 9b23203c32ee02cd ("ravb: Mask PHY mode to avoid inserting
>     delays twice").
> Signed-off-by: Geert Uytterhoeven <>
> Reviewed-by: Sergei Shtylyov <>

Reviewed-by: Florian Fainelli <>

Powered by blists - more mailing lists