netdev - Re: [RESEND PATCH] net: dsa: microchip: look for phy-mode in port nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200824.153738.1423061044322742575.davem@davemloft.net>
Date:   Mon, 24 Aug 2020 15:37:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     helmut.grohne@...enta.de
Cc:     nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
        ludovic.desroches@...rochip.com, woojung.huh@...rochip.com,
        UNGLinuxDriver@...rochip.com, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com, kuba@...nel.org,
        robh+dt@...nel.org, devicetree@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [RESEND PATCH] net: dsa: microchip: look for phy-mode in port
 nodes

From: Helmut Grohne <helmut.grohne@...enta.de>
Date: Thu, 20 Aug 2020 08:03:33 +0200

> diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
> index 8d53b12d40a8..d96b7ab6bb15 100644
> --- a/drivers/net/dsa/microchip/ksz_common.c
> +++ b/drivers/net/dsa/microchip/ksz_common.c
> @@ -389,6 +389,8 @@ int ksz_switch_register(struct ksz_device *dev,
>  {
>  	phy_interface_t interface;
>  	int ret;
> +	struct device_node *port;
> +	unsigned int port_num;
>  
>  	if (dev->pdata)
>  		dev->chip_id = dev->pdata->chip_id;

Please preserve the reverse christmas tree ordering of local variables here.