netdev - Re: [PATCH net-next v3 2/2] io_uring: ignore POLLIN for recvmsg on MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200824.161655.863789085344308332.davem@davemloft.net>
Date:   Mon, 24 Aug 2020 16:16:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     luke.w.hsiao@...il.com
Cc:     netdev@...r.kernel.org, axboe@...nel.dk, kuba@...nel.org,
        lukehsiao@...gle.com, arjunroy@...gle.com, soheil@...gle.com,
        edumazet@...gle.com
Subject: Re: [PATCH net-next v3 2/2] io_uring: ignore POLLIN for recvmsg on
 MSG_ERRQUEUE

From: Luke Hsiao <luke.w.hsiao@...il.com>
Date: Fri, 21 Aug 2020 21:41:05 -0700

> From: Luke Hsiao <lukehsiao@...gle.com>
> 
> Currently, io_uring's recvmsg subscribes to both POLLERR and POLLIN. In
> the context of TCP tx zero-copy, this is inefficient since we are only
> reading the error queue and not using recvmsg to read POLLIN responses.
> 
> This patch was tested by using a simple sending program to call recvmsg
> using io_uring with MSG_ERRQUEUE set and verifying with printks that the
> POLLIN is correctly unset when the msg flags are MSG_ERRQUEUE.

Again, selftests additions please.

> Signed-off-by: Arjun Roy <arjunroy@...gle.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Acked-by: Eric Dumazet <edumazet@...gle.com>
> Reviewed-by: Jens Axboe <axboe@...nel.dk>
> Signed-off-by: Luke Hsiao <lukehsiao@...gle.com>

Applied.