netdev - Re: [PATCH V3] net: dsa: Add of_node_put() before break and return statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200824.062052.523630350034926727.davem@davemloft.net>
Date:   Mon, 24 Aug 2020 06:20:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sylphrenadin@...il.com
Cc:     Julia.Lawall@...6.fr, andrew@...n.ch, sean.wang@...iatek.com,
        vivien.didelot@...il.com, f.fainelli@...il.com, kuba@...nel.org,
        matthias.bgg@...il.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] net: dsa: Add of_node_put() before break and return
 statements

From: Sumera Priyadarsini <sylphrenadin@...il.com>
Date: Mon, 24 Aug 2020 01:00:54 +0530

> ---
> 
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@...il.com>
> 
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@...il.com>

You only need one Signed-off-by:

You must not put the signoff after the "---" otherwise GIT will remove
it from the commit log message when I try to apply your patch.

Combine this with the fact that your change didn't even compile
properly up until even V2, I wish you would put more effort and
care into your patch submission.  It feels to reviewers like
you are just throwing this patch onto the mailing list without
much care or testing at all.

Thank you.