netdev - Re: [PATCH net] ipv6: ndisc: adjust ndisc_ifinfo_sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200824.064030.508387089672625330.davem@davemloft.net>
Date:   Mon, 24 Aug 2020 06:40:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tklauser@...tanz.ch
Cc:     kuba@...nel.org, netdev@...r.kernel.org, hch@....de
Subject: Re: [PATCH net] ipv6: ndisc: adjust ndisc_ifinfo_sysctl_change
 prototype

From: Tobias Klauser <tklauser@...tanz.ch>
Date: Mon, 24 Aug 2020 13:46:22 +0200

> Commit 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler")
> changed ndisc_ifinfo_sysctl_change to take a kernel pointer. Adjust its
> prototype in net/ndisc.h as well to fix the following sparse warning:
> 
> net/ipv6/ndisc.c:1838:5: error: symbol 'ndisc_ifinfo_sysctl_change' redeclared with different type (incompatible argument 3 (different address spaces)):
> net/ipv6/ndisc.c:1838:5:    int extern [addressable] [signed] [toplevel] ndisc_ifinfo_sysctl_change( ... )
> net/ipv6/ndisc.c: note: in included file (through include/net/ipv6.h):
> ./include/net/ndisc.h:496:5: note: previously declared as:
> ./include/net/ndisc.h:496:5:    int extern [addressable] [signed] [toplevel] ndisc_ifinfo_sysctl_change( ... )
> net/ipv6/ndisc.c: note: in included file (through include/net/ip6_route.h):
> 
> Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler")
> Cc: Christoph Hellwig <hch@....de>
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Applied, thank you.