netdev - Re: [PATCH v7 net-next 0/3] Add PTP support for Octeontx2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Aug 2020 20:01:38 +0530
From:   sundeep subbaraya <sundeep.lkml@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Richard Cochran <richardcochran@...il.com>,
        netdev@...r.kernel.org, sgoutham@...vell.com,
        Subbaraya Sundeep <sbhatta@...vell.com>
Subject: Re: [PATCH v7 net-next 0/3] Add PTP support for Octeontx2

Hi David,

On Mon, Aug 24, 2020 at 6:47 PM David Miller <davem@...emloft.net> wrote:
>
> From: David Miller <davem@...emloft.net>
> Date: Mon, 24 Aug 2020 06:16:57 -0700 (PDT)
>
> > Series applied, thank you.
>
> Actually, this doesn't even compile:
>
Our Marvell GCC10 ARM64 compiler did not complain anything about this
even with W=1 and my bad I overlooked the missing header file inclusion.
The same happened during V1 where the power-pc compiler caught a
similar error and ours did not.
Sorry for the trouble, I will send the next spin.

Thanks,
Sundeep

> drivers/net/ethernet/marvell/octeontx2/af/ptp.c: In function ‘get_clock_rate’:
> drivers/net/ethernet/marvell/octeontx2/af/ptp.c:60:26: error: implicit declaration of function ‘FIELD_GET’; did you mean ‘FOLL_GET’? [-Werror=implicit-function-declaration]
>    60 |  ret = CLOCK_BASE_RATE * FIELD_GET(RST_MUL_BITS, cfg);
>       |                          ^~~~~~~~~
>       |                          FOLL_GET