netdev - Re: [PATCH] chelsio: switch from 'pci_' to 'dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200824.175637.805257656507953369.davem@davemloft.net>
Date:   Mon, 24 Aug 2020 17:56:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     christophe.jaillet@...adoo.fr
Cc:     kuba@...nel.org, leon@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] chelsio: switch from 'pci_' to 'dma_' API

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Date: Sun, 23 Aug 2020 10:36:48 +0200

> The wrappers in include/linux/pci-dma-compat.h should go away.
> 
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
> 
> When memory is allocated in 'free_rx_resources()' and
> 'alloc_tx_resources()' (sge.c) GFP_KERNEL can be used because it is
> already used in these functions.
> 
> Moreover, they can only be called from a .ndo_open	function. So it is
> guarded by the 'rtnl_lock()', which is a mutex.
> 
> While at it, a pr_err message in 'init_one()' has been updated accordingly
> (s/consistent/coherent).
 ...
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied, thanks.