netdev - Re: [PATCH net-next 07/18] gve: Use link status register to report link status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL9ddJcwy9QoJ5=N_A+9PK5aU4HVTxLxyZVjy+7niHcoQMZ-Yg@mail.gmail.com>
Date:   Tue, 25 Aug 2020 08:46:35 -0700
From:   David Awogbemila <awogbemila@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Patricio Noyola <patricion@...gle.com>,
        Yangchun Fu <yangchun@...gle.com>
Subject: Re: [PATCH net-next 07/18] gve: Use link status register to report
 link status

On Tue, Aug 18, 2020 at 8:36 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 18 Aug 2020 12:44:06 -0700 David Awogbemila wrote:
> > +     if (link_status) {
> > +             netif_carrier_on(priv->dev);
> > +     } else {
> > +             dev_info(&priv->pdev->dev, "Device link is down.\n");
>
> Down message but no Up message?
>
> > +             netif_carrier_off(priv->dev);

Thanks Jakub. I'll add an Up message to make it more uniform.